[llvm] AMDGPU: Replace sqrt OpenCL libcalls with llvm.sqrt (PR #74197)

Stanislav Mekhanoshin via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 15 00:35:49 PST 2023


rampitec wrote:

> > So I suggest adding the first test (with fast) and removing nsz in the second. The rest seems OK.
> 
> nsz doesn't do anything for sqrt lowering. Signed zero works correctly in the instruction. We have an excess of messy and overlapping sqrt tests as is, I don't think we need to add any new ones. Adding tests with "fast" will just add to the mess. We should drop the nsz and possibly any using the unsafe-fp-math attributes

And then if you want to drop attribute handling that is a completely different change and a different discussion. You claim here is no regressions.

https://github.com/llvm/llvm-project/pull/74197


More information about the llvm-commits mailing list