[llvm] [AArch64] Put legal action first for G_ATOMIC_CMPXCHG (PR #74613)

Pavel Iliin via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 11:11:51 PST 2023


================
@@ -758,18 +758,16 @@ AArch64LegalizerInfo::AArch64LegalizerInfo(const AArch64Subtarget &ST)
           all(typeInSet(0, {s8, s16, s32, s64, s128}), typeIs(2, p0)));
 
   getActionDefinitionsBuilder(G_ATOMIC_CMPXCHG)
-      .customIf([](const LegalityQuery &Query) {
-        return Query.Types[0].getSizeInBits() == 128;
-      })
-      .clampScalar(0, s32, s64)
-      .legalIf(all(typeInSet(0, {s32, s64}), typeIs(1, p0)));
+      .legalFor({{s32, p0}, {s64, p0}})
+      .customIf(typeIs(0, s128))
----------------
ilinpv wrote:

Looks like rule on 128-bit vector types case was removed, but not sure if it was needed. Is the patch meant to be NFC?

https://github.com/llvm/llvm-project/pull/74613


More information about the llvm-commits mailing list