[llvm] [llvm-cxxfilt] Added the option --no-params (PR #75348)
Dmitry Vasilyev via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 14 05:00:15 PST 2023
slydiman wrote:
> note the parentheses at the end in the thing you've implemented, whereas these are not present in the GNU output.
Note `NodeArray Params` is required parameter for the class FunctionEncoding. All other parts are `const Node *` and may be nullptr. We can update Params type to `const NodeArray *` and update the printing logic in FunctionEncoding::printRight() like
```
if (Params) {
OB.printOpen();
Params->printWithComma(OB);
OB.printClose();
}
```
But I think it is redundant. It requires to review all FunctionEncoding::getParams() usage too.
https://github.com/llvm/llvm-project/pull/75348
More information about the llvm-commits
mailing list