[llvm] [llvm-objdump] Add the --visualize-jumps option (PR #74858)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 01:01:46 PST 2023


================
@@ -1218,9 +1294,9 @@ static void dumpELFData(uint64_t SectionAddr, uint64_t Index, uint64_t End,
     }
     if (NumBytes == 8) {
       AsciiData[8] = '\0';
-      outs() << std::string(IndentOffset, ' ') << "         ";
-      outs() << reinterpret_cast<char *>(AsciiData);
-      outs() << '\n';
+      OS << std::string(IndentOffset, ' ') << "         ";
+      OS << reinterpret_cast<char *>(AsciiData);
----------------
jh7370 wrote:

FWIW, this `reinterpret_cast` is probably pointless, since I expect `uint8_t` to be printed identically to a `char`, based on past experience. However, I don't object to it being left in for clarity.

https://github.com/llvm/llvm-project/pull/74858


More information about the llvm-commits mailing list