[llvm] [llvm-objdump] Add the --visualize-jumps option (PR #74858)

James Henderson via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 14 01:01:43 PST 2023


================
@@ -291,6 +291,36 @@ OPTIONS
 
   Target triple to disassemble for, see ``--version`` for available targets.
 
+.. option:: --visualize-jumps=<modes>
+
+  Display a control-flow graph which shows the targets of branch instructions to the left of disasembly. ``modes`` is a comma-separated list of options, which configure the character set and used to print the graph.
+
+  If ``modes`` is omitted, the default is ``unicode,auto``
+
+   .. option:: off
----------------
jh7370 wrote:

Have you built and inspected the documentation? I don't have a currently working doc build, so I can't myself, but I'd be slightly concerned that this would look like a general command, rather than an argument of the `--visualize-jumps` option. `--disassembler-color` uses a different format. Perhaps that should be what you follow for consistency?

Oh, hang on, looking downwards, I see the `--x86-asm-syntax=<style>` is formatted this way. I personally prefer the bullet points of `--disassembler-color` (plus it's used in another place too), so I still think you should change.

https://github.com/llvm/llvm-project/pull/74858


More information about the llvm-commits mailing list