[llvm] [RISCV] Simplify PrintExtension. NFC (PR #75427)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 13 21:22:22 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-risc-v
Author: Craig Topper (topperc)
<details>
<summary>Changes</summary>
Instead of using a format string that needs to be parsed, we can use left_justify to print each string with padding.
---
Full diff: https://github.com/llvm/llvm-project/pull/75427.diff
1 Files Affected:
- (modified) llvm/lib/Support/RISCVISAInfo.cpp (+8-7)
``````````diff
diff --git a/llvm/lib/Support/RISCVISAInfo.cpp b/llvm/lib/Support/RISCVISAInfo.cpp
index 85c34dd620630..245d1e67343a9 100644
--- a/llvm/lib/Support/RISCVISAInfo.cpp
+++ b/llvm/lib/Support/RISCVISAInfo.cpp
@@ -215,11 +215,12 @@ static void verifyTables() {
#endif
}
-static void PrintExtension(const std::string Name, const std::string Version,
- const std::string Description) {
- outs() << " "
- << format(Description.empty() ? "%-20s%s\n" : "%-20s%-10s%s\n",
- Name.c_str(), Version.c_str(), Description.c_str());
+static void PrintExtension(StringRef Name, StringRef Version,
+ StringRef Description) {
+ outs().indent(4);
+ unsigned VersionWidth = Description.empty() ? 0 : 10;
+ outs() << left_justify(Name, 20) << left_justify(Version, VersionWidth)
+ << Description << "\n";
}
void llvm::riscvExtensionsHelp(StringMap<StringRef> DescMap) {
@@ -233,7 +234,7 @@ void llvm::riscvExtensionsHelp(StringMap<StringRef> DescMap) {
for (const auto &E : ExtMap) {
std::string Version = std::to_string(E.second.MajorVersion) + "." +
std::to_string(E.second.MinorVersion);
- PrintExtension(E.first, Version, DescMap[E.first].str());
+ PrintExtension(E.first, Version, DescMap[E.first]);
}
outs() << "\nExperimental extensions\n";
@@ -243,7 +244,7 @@ void llvm::riscvExtensionsHelp(StringMap<StringRef> DescMap) {
for (const auto &E : ExtMap) {
std::string Version = std::to_string(E.second.MajorVersion) + "." +
std::to_string(E.second.MinorVersion);
- PrintExtension(E.first, Version, DescMap["experimental-" + E.first].str());
+ PrintExtension(E.first, Version, DescMap["experimental-" + E.first]);
}
outs() << "\nUse -march to specify the target's extension.\n"
``````````
</details>
https://github.com/llvm/llvm-project/pull/75427
More information about the llvm-commits
mailing list