[llvm] [RISCV] Remove mfd and mpd CSR names for SiFive. (PR #75392)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 14:06:06 PST 2023


https://github.com/topperc created https://github.com/llvm/llvm-project/pull/75392

These names do not appear in the spec that was referenced for their addition. They appear to have been made up for LLVM.

These also don't belong to Xsfcie which is not an official SiFive extension name and appears to have been made up for LLVM too.

I made a big mistake in approving the original patches.

There are no official names defined currently. I'm willing to help get names defined, but only if the names are really needed.

>From e8c4b4a0fb13cf2db468845ce1c1c90152f3dd1b Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Wed, 13 Dec 2023 13:56:55 -0800
Subject: [PATCH] [RISCV] Remove mfd and mpd CSR names for SiFive.

These names do not appear in the spec that was referenced for their
addition. They appear to have been made up for LLVM.

These also don't belong to Xsfcie which is not an official SiFive
extension name and appears to have been made up for LLVM too.

I made a big mistake in approving the original patches.

There are no official names defined currently. I'm willing to help
get names defined, but only if the names are really needed.
---
 llvm/lib/Target/RISCV/RISCVSystemOperands.td | 2 --
 1 file changed, 2 deletions(-)

diff --git a/llvm/lib/Target/RISCV/RISCVSystemOperands.td b/llvm/lib/Target/RISCV/RISCVSystemOperands.td
index 953df7b15e2f6c..cf721fc80cb5f4 100644
--- a/llvm/lib/Target/RISCV/RISCVSystemOperands.td
+++ b/llvm/lib/Target/RISCV/RISCVSystemOperands.td
@@ -332,8 +332,6 @@ def : SiFiveReg<"mnepc", 0x351>;
 def : SiFiveReg<"mncause", 0x352>;
 def : SiFiveReg<"mnstatus", 0x353>;
 def : SiFiveReg<"mbpm", 0x7C0>;
-def : SiFiveReg<"mfd", 0x7C1>;
-def : SiFiveReg<"mpd", 0x7C8>;
 }
 
 //===----------------------------------------------------------------------===//



More information about the llvm-commits mailing list