[llvm] [llvm-cxxfilt] Added the option --no-params (PR #75348)

via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 13 07:26:48 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 05b68d596047cf50f721eea1c69275f8906ba561 02a567da51b82a63e46481f68ac3a1c1cdea86ef -- llvm/include/llvm/Demangle/Demangle.h llvm/include/llvm/Demangle/ItaniumDemangle.h llvm/lib/Demangle/Demangle.cpp llvm/lib/Demangle/ItaniumDemangle.cpp llvm/tools/llvm-cxxfilt/llvm-cxxfilt.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/include/llvm/Demangle/Demangle.h b/llvm/include/llvm/Demangle/Demangle.h
index 4174a16017..fe129603c0 100644
--- a/llvm/include/llvm/Demangle/Demangle.h
+++ b/llvm/include/llvm/Demangle/Demangle.h
@@ -68,7 +68,8 @@ char *dlangDemangle(std::string_view MangledName);
 std::string demangle(std::string_view MangledName);
 
 bool nonMicrosoftDemangle(std::string_view MangledName, std::string &Result,
-                          bool CanHaveLeadingDot = true, bool ParseParams = true);
+                          bool CanHaveLeadingDot = true,
+                          bool ParseParams = true);
 
 /// "Partial" demangler. This supports demangling a string into an AST
 /// (typically an intermediate stage in itaniumDemangle) and querying certain
diff --git a/llvm/include/llvm/Demangle/ItaniumDemangle.h b/llvm/include/llvm/Demangle/ItaniumDemangle.h
index 619bb93ab1..fcacfa2b09 100644
--- a/llvm/include/llvm/Demangle/ItaniumDemangle.h
+++ b/llvm/include/llvm/Demangle/ItaniumDemangle.h
@@ -5452,13 +5452,13 @@ Node *AbstractManglingParser<Derived, Alloc>::parseEncoding(bool ParseParams) {
   }
 
   NodeArray Params;
-  
+
   // ParseParams may be false in top-level only, when called from parse().
   if (!ParseParams) {
-    while (consume());
+    while (consume())
+      ;
     return make<FunctionEncoding>(ReturnType, Name, Params, Attrs,
-                                  nullptr /* Requires */,
-                                  NameInfo.CVQualifiers,
+                                  nullptr /* Requires */, NameInfo.CVQualifiers,
                                   NameInfo.ReferenceQualifier);
   }
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/75348


More information about the llvm-commits mailing list