[llvm] [RFC][RISCV] Support the large code model. (PR #70308)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 12 22:01:28 PST 2023
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff ec6da0652282d29569faa628d2180909fa588906 c30d948788ae8aeaa246e6effb7b17b454f0d691 -- llvm/lib/Target/RISCV/RISCVConstantPoolValue.cpp llvm/lib/Target/RISCV/RISCVConstantPoolValue.h llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp llvm/lib/Target/RISCV/RISCVISelLowering.cpp llvm/lib/Target/RISCV/RISCVTargetObjectFile.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp b/llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
index 26e5e63db3..157703c5ed 100644
--- a/llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
+++ b/llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp
@@ -1002,8 +1002,8 @@ void RISCVAsmPrinter::emitMachineConstantPoolValue(
MCSym = GetExternalSymbolSymbol(Sym);
}
- const MCExpr *Expr = MCSymbolRefExpr::create(
- MCSym, MCSymbolRefExpr::VK_None, OutContext);
+ const MCExpr *Expr =
+ MCSymbolRefExpr::create(MCSym, MCSymbolRefExpr::VK_None, OutContext);
uint64_t Size = getDataLayout().getTypeAllocSize(RCPV->getType());
OutStreamer->emitValue(Expr, Size);
}
diff --git a/llvm/lib/Target/RISCV/RISCVConstantPoolValue.cpp b/llvm/lib/Target/RISCV/RISCVConstantPoolValue.cpp
index c47ad35d18..e548e88fff 100644
--- a/llvm/lib/Target/RISCV/RISCVConstantPoolValue.cpp
+++ b/llvm/lib/Target/RISCV/RISCVConstantPoolValue.cpp
@@ -21,12 +21,12 @@
using namespace llvm;
-RISCVConstantPoolValue::RISCVConstantPoolValue(
- LLVMContext &C, RISCVCP::RISCVCPKind Kind)
+RISCVConstantPoolValue::RISCVConstantPoolValue(LLVMContext &C,
+ RISCVCP::RISCVCPKind Kind)
: MachineConstantPoolValue((Type *)Type::getInt64Ty(C)), Kind(Kind) {}
-RISCVConstantPoolValue::RISCVConstantPoolValue(
- Type *Ty, RISCVCP::RISCVCPKind Kind)
+RISCVConstantPoolValue::RISCVConstantPoolValue(Type *Ty,
+ RISCVCP::RISCVCPKind Kind)
: MachineConstantPoolValue(Ty), Kind(Kind) {}
int RISCVConstantPoolValue::getExistingMachineCPValue(MachineConstantPool *CP,
@@ -73,12 +73,11 @@ const BlockAddress *RISCVConstantPoolConstant::getBlockAddress() const {
return dyn_cast_or_null<BlockAddress>(CVal);
}
-RISCVConstantPoolSymbol::RISCVConstantPoolSymbol(
- LLVMContext &C, StringRef s)
+RISCVConstantPoolSymbol::RISCVConstantPoolSymbol(LLVMContext &C, StringRef s)
: RISCVConstantPoolValue(C, RISCVCP::ExtSymbol), S(s) {}
-RISCVConstantPoolSymbol *
-RISCVConstantPoolSymbol::Create(LLVMContext &C, StringRef s) {
+RISCVConstantPoolSymbol *RISCVConstantPoolSymbol::Create(LLVMContext &C,
+ StringRef s) {
return new RISCVConstantPoolSymbol(C, s);
}
@@ -91,6 +90,4 @@ void RISCVConstantPoolSymbol::addSelectionDAGCSEId(FoldingSetNodeID &ID) {
ID.AddString(S);
}
-void RISCVConstantPoolSymbol::print(raw_ostream &O) const {
- O << S;
-}
+void RISCVConstantPoolSymbol::print(raw_ostream &O) const { O << S; }
diff --git a/llvm/lib/Target/RISCV/RISCVConstantPoolValue.h b/llvm/lib/Target/RISCV/RISCVConstantPoolValue.h
index 901e09bee2..ca6c714e32 100644
--- a/llvm/lib/Target/RISCV/RISCVConstantPoolValue.h
+++ b/llvm/lib/Target/RISCV/RISCVConstantPoolValue.h
@@ -115,9 +115,7 @@ public:
void print(raw_ostream &O) const override;
- bool equals(const RISCVConstantPoolSymbol *A) const {
- return S == A->S;
- }
+ bool equals(const RISCVConstantPoolSymbol *A) const { return S == A->S; }
static bool classof(const RISCVConstantPoolValue *RCPV) {
return RCPV->isExtSymbol();
}
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
index 95d42ed792..0572dea571 100644
--- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -6456,8 +6456,8 @@ static SDValue getLargeAddr(NodeTy *N, SDLoc DL, EVT Ty, SelectionDAG &DAG) {
Ty, DL, DAG.getEntryNode(), LC,
MachinePointerInfo::getConstantPool(DAG.getMachineFunction()));
} else if (ExternalSymbolSDNode *S = dyn_cast<ExternalSymbolSDNode>(N)) {
- RISCVConstantPoolSymbol *CPV = RISCVConstantPoolSymbol::Create(
- *DAG.getContext(), S->getSymbol());
+ RISCVConstantPoolSymbol *CPV =
+ RISCVConstantPoolSymbol::Create(*DAG.getContext(), S->getSymbol());
SDValue CPAddr = DAG.getTargetConstantPool(CPV, Ty, Align(8));
SDValue LC = DAG.getNode(RISCVISD::LLA, DL, Ty, CPAddr);
return DAG.getLoad(
``````````
</details>
https://github.com/llvm/llvm-project/pull/70308
More information about the llvm-commits
mailing list