[lld] [lld][WebAssembly] Don't set importUndefined when -shared is used. NFC (PR #75241)

via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 12:12:10 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-lld

@llvm/pr-subscribers-lld-wasm

Author: Sam Clegg (sbc100)

<details>
<summary>Changes</summary>

`importUndefined` is only used a couple of places and both of those already handle `isPic` separately.

---
Full diff: https://github.com/llvm/llvm-project/pull/75241.diff


1 Files Affected:

- (modified) lld/wasm/Driver.cpp (-1) 


``````````diff
diff --git a/lld/wasm/Driver.cpp b/lld/wasm/Driver.cpp
index f8b0fc357bd90c..c68fe33a14e29d 100644
--- a/lld/wasm/Driver.cpp
+++ b/lld/wasm/Driver.cpp
@@ -606,7 +606,6 @@ static void setConfigs() {
       config->memoryImport =
           std::pair<llvm::StringRef, llvm::StringRef>(defaultModule, memoryName);
     }
-    config->importUndefined = true;
   }
 
   // If neither export-memory nor import-memory is specified, default to

``````````

</details>


https://github.com/llvm/llvm-project/pull/75241


More information about the llvm-commits mailing list