[llvm] [llvm][NVPTX] Inform that 'DYNAMIC_STACKALLOC' is unsupported (PR #74684)

Yingchi Long via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 06:33:36 PST 2023


================
@@ -2652,6 +2657,9 @@ NVPTXTargetLowering::LowerOperation(SDValue Op, SelectionDAG &DAG) const {
   case ISD::SREM:
   case ISD::UREM:
     return LowerVectorArith(Op, DAG);
+  case ISD::DYNAMIC_STACKALLOC:
+    report_fatal_error(
----------------
inclyc wrote:

> Thanks for your feedback! I'll update the PR to trigger a diagnostic instead.
> 
> P.s. I mimicked the `report_fatal_error` approach from BPFISelLowering. That part could use a similar improvement as well.
> 
> https://github.com/llvm/llvm-project/blob/a2161154334355e9ecdf3cc3a0303b9481aad897/llvm/lib/Target/BPF/BPFISelLowering.cpp#L311
> 
> .

Yes, I just submitted a PR to address this  https://github.com/llvm/llvm-project/pull/75088

https://github.com/llvm/llvm-project/pull/74684


More information about the llvm-commits mailing list