[llvm] [RemoveDIs][NFC] Find DPValues using findDbgDeclares (PR #73500)

Jeremy Morse via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 12 04:21:09 PST 2023


https://github.com/jmorse approved this pull request.

LGTM -- I'm aware of a convention where you have the "End" enumeration name take the same value as the final enumeration name, so `End = Value,`, so that you don't need to have a useless "case End:" in any switch statements. However, that might be a C thing rather than a C++ thing, so feel free to ignore.

https://github.com/llvm/llvm-project/pull/73500


More information about the llvm-commits mailing list