[llvm] 1f71db7 - [NFC][DSE] Fix typo comment in eliminateDeadStores (#75166)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Dec 12 03:13:45 PST 2023
Author: Nabeel Omer
Date: 2023-12-12T11:13:40Z
New Revision: 1f71db78ce2b5cc7af86271276d039e4e87146d3
URL: https://github.com/llvm/llvm-project/commit/1f71db78ce2b5cc7af86271276d039e4e87146d3
DIFF: https://github.com/llvm/llvm-project/commit/1f71db78ce2b5cc7af86271276d039e4e87146d3.diff
LOG: [NFC][DSE] Fix typo comment in eliminateDeadStores (#75166)
> We are re-using tryToMergePartialOverlappingStores, which requires
DeadSI to dominate DeadSI.
Should be "DeadSI to dominate KillingSI" because that's what the check
is for.
Added:
Modified:
llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
Removed:
################################################################################
diff --git a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
index dd0a290252dae3..008dcc53fd44fc 100644
--- a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
@@ -2170,7 +2170,7 @@ static bool eliminateDeadStores(Function &F, AliasAnalysis &AA, MemorySSA &MSSA,
auto *DeadSI = dyn_cast<StoreInst>(DeadI);
auto *KillingSI = dyn_cast<StoreInst>(KillingI);
// We are re-using tryToMergePartialOverlappingStores, which requires
- // DeadSI to dominate DeadSI.
+ // DeadSI to dominate KillingSI.
// TODO: implement tryToMergeParialOverlappingStores using MemorySSA.
if (DeadSI && KillingSI && DT.dominates(DeadSI, KillingSI)) {
if (Constant *Merged = tryToMergePartialOverlappingStores(
More information about the llvm-commits
mailing list