[llvm] [TextAPI] Add DylibReader (PR #75006)

Cyndy Ishida via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 15:52:57 PST 2023


================
@@ -103,6 +103,10 @@ class GlobalRecord : public Record {
 
   bool isFunction() const { return GV == Kind::Function; }
   bool isVariable() const { return GV == Kind::Variable; }
+  void setKind(const Kind &V) {
----------------
cyndyishida wrote:

While I agree, I also wanted to keep the `const` mostly to ensure that the passed value isn't modified, just assigned. But that puts us back to https://github.com/llvm/llvm-project/pull/75006#discussion_r1422148304

https://github.com/llvm/llvm-project/pull/75006


More information about the llvm-commits mailing list