[llvm] [TextAPI] Add DylibReader (PR #75006)

Juergen Ributzka via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 15:46:59 PST 2023


================
@@ -103,6 +103,10 @@ class GlobalRecord : public Record {
 
   bool isFunction() const { return GV == Kind::Function; }
   bool isVariable() const { return GV == Kind::Variable; }
+  void setKind(const Kind &V) {
----------------
ributzka wrote:

In this case I would prefer to pass the argument by value. It is only an `uint8_t` enum. There is no need to pass it by reference.

https://github.com/llvm/llvm-project/pull/75006


More information about the llvm-commits mailing list