davemgreen wrote: I see you've removed i256 atomics from some of the tests (makes sense). Should we be adding i256 tests somewhere now, to test what this patch is aiming to fix? https://github.com/llvm/llvm-project/pull/74385