[llvm] [SPIR-V][NFC] Require asserts on 2 tests (PR #75087)

Natalie Chouinard via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 11:00:26 PST 2023


https://github.com/sudonatalie created https://github.com/llvm/llvm-project/pull/75087

These tests currently fail on asserts, so adding a REQUIRES to make sure they're skipped on builds with asserts disabled.

Follow-up from #74849

>From f879b67270b8e7ef4cb9ff88d8ca4377cdaf07c8 Mon Sep 17 00:00:00 2001
From: Natalie Chouinard <chouinard at google.com>
Date: Mon, 11 Dec 2023 18:56:16 +0000
Subject: [PATCH] [SPIR-V][NFC] Require asserts on 2 tests

These tests currently fail on asserts, so adding a REQUIRES to make sure
they're skipped on builds with asserts disabled.

Follow-up from #74849
---
 llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll | 1 +
 llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll            | 1 +
 2 files changed, 2 insertions(+)

diff --git a/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll b/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll
index b001ce09f5679..1df72dc734dbd 100644
--- a/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll
+++ b/llvm/test/CodeGen/SPIRV/opencl/device_execution/execute_block.ll
@@ -2,6 +2,7 @@
 
 ; TODO(#60133): Requires updates following opaque pointer migration.
 ; XFAIL: *
+; REQUIRES: asserts
 
 ; CHECK: %[[#bool:]] = OpTypeBool
 ; CHECK: %[[#true:]] = OpConstantTrue %[[#bool]]
diff --git a/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll b/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
index 75aa87f958d47..a2ae808259a32 100644
--- a/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
+++ b/llvm/test/CodeGen/SPIRV/transcoding/BuildNDRange_2.ll
@@ -22,6 +22,7 @@
 
 ; TODO(#60133): Requires updates following opaque pointer migration.
 ; XFAIL: *
+; REQUIRES: asserts
 
 ; CHECK-SPIRV-DAG:     %[[#LEN2_ID:]] = OpConstant %[[#]] 2
 ; CHECK-SPIRV-DAG:     %[[#LEN3_ID:]] = OpConstant %[[#]] 3



More information about the llvm-commits mailing list