[llvm] [NFC] Change FindDbgDeclareUsers interface to match findDbgUsers/values (PR #73498)
Felipe de Azevedo Piovezan via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 11 07:58:45 PST 2023
================
@@ -40,7 +40,7 @@ class Module;
/// Finds dbg.declare intrinsics declaring local variables as living in the
/// memory that 'V' points to.
-TinyPtrVector<DbgDeclareInst *> FindDbgDeclareUses(Value *V);
+void findDbgDeclares(SmallVectorImpl<DbgDeclareInst *> &DbgUsers, Value *V);
----------------
felipepiovezan wrote:
> FYI
>
> > Forgive me if I mentioned this in another patch (I couldn't find it), but why insist on using out parameters instead of returning a pair of vectors?
>
> It was in #74480, for a similar function.
Ohh thank you! That reminds me I need to get back to that review. I keep clicking the "pull requests" view of Github hoping it will show all reviews I am involved in, but sadly it doesn't :(
https://github.com/llvm/llvm-project/pull/73498
More information about the llvm-commits
mailing list