[llvm] [Dexter] Set ShouldBuild=false for Visual Studio solutions (PR #75045)

Stephen Tozer via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 11 04:42:31 PST 2023


https://github.com/SLTozer created https://github.com/llvm/llvm-project/pull/75045

Since Dexter no longer intends to build any code, the ShouldBuild property in any Visual Studio project being run by Dexter should be false to ensure that a build step is never invoked by Dexter, whether the project has already been built or not.

>From 2231464a485629d6262792a0d712c0ad439e56d3 Mon Sep 17 00:00:00 2001
From: Stephen Tozer <Stephen.Tozer at Sony.com>
Date: Mon, 11 Dec 2023 12:35:30 +0000
Subject: [PATCH] [Dexter] Set ShouldBuild=false for Visual Studio solutions

Since Dexter no longer intends to build any code, the ShouldBuild property
in any Visual Studio project being run by Dexter should be false to ensure
that a build step is never invoked by Dexter, whether the project has
already been built or not.
---
 .../dexter/dex/debugger/visualstudio/VisualStudio.py       | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
index 50a97e2b77d15d..0e20cfbbd264b2 100644
--- a/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
+++ b/cross-project-tests/debuginfo-tests/dexter/dex/debugger/visualstudio/VisualStudio.py
@@ -276,6 +276,13 @@ def launch(self, cmdline):
             project.Properties, "ActiveConfiguration"
         ).Object
         ActiveConfiguration.DebugSettings.CommandArguments = cmdline_str
+        ConfigurationName = ActiveConfiguration.ConfigurationName
+        SolConfig = self._fetch_property(
+            self._interface.Solution.SolutionBuild.SolutionConfigurations,
+            ConfigurationName,
+        )
+        for Context in SolConfig.SolutionContexts:
+            Context.ShouldBuild = False
 
         self.context.logger.note("Launching VS debugger...")
         self._fn_go(False)



More information about the llvm-commits mailing list