[llvm] [CodeGen] Port `GCInfoPrinter` to new pass manager (PR #74972)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 10 18:23:12 PST 2023


================
@@ -101,7 +189,7 @@ void Printer::getAnalysisUsage(AnalysisUsage &AU) const {
 }
 
 bool Printer::runOnFunction(Function &F) {
-  if (F.hasGC())
+  if (!F.hasGC())
----------------
boomanaiden154 wrote:

Ah, yep. Looks like in https://github.com/llvm/llvm-project/commit/d930f913e6a7cef110d9b62e8218c8845fe8e026 this got switched from `F.hasCollector()` to `F.hasGC()` (well, the non-early exit version so technically `!F.hasGC()`). So it seems like this has been broken in tree for 15+ years (as far as I can understand). Maybe we just want to remove it?

https://github.com/llvm/llvm-project/pull/74972


More information about the llvm-commits mailing list