[llvm] [llvm][NFC] Refactor AutoUpgrader arm/aarch64 (PR #74145)

Nathan Sidwell via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 8 10:43:00 PST 2023


================
@@ -621,6 +621,318 @@ static bool UpgradeX86IntrinsicFunction(Function *F, StringRef Name,
   return false;
 }
 
+// Upgrade ARM (IsArm) or Aarch64 (!IsArm) intrinsic fns. Return true iff so.
+// IsArm: 'arm.*', !IsArm: 'aarch64.*'.
+static bool UpgradeArmOrAarch64IntrinsicFunction(bool IsArm, Function *F,
----------------
urnathan wrote:

While I'm fine with this, it wouldn't match the other broken-out static names:
```
static bool ShouldUpgradeX86Intrinsic(Function *F, StringRef Name) {
static bool UpgradeX86IntrinsicFunction(Function *F, StringRef Name,
static Intrinsic::ID ShouldUpgradeNVPTXBF16Intrinsic(StringRef Name) {
```

perhaps a separate renaming patch?

https://github.com/llvm/llvm-project/pull/74145


More information about the llvm-commits mailing list