[llvm] [LLVM][IR] Add textual shorthand for specifying constant vector splats. (PR #74620)

[Nikita Popov via llvm-commits]

================
@@ -3981,6 +3981,21 @@ bool LLParser::parseValID(ValID &ID, PerFunctionState *PFS, Type *ExpectedTy) {
     return false;
   }
 
+  case lltok::kw_splat: {
+    Lex.Lex();
+    if (parseToken(lltok::lparen, "expected '(' after vector splat"))
+      return true;
+    Constant *C;
+    if (parseGlobalTypeAndValue(C))
+      return true;
+    if (parseToken(lltok::rparen, "expected ')' at end of vector splat"))
+      return true;
+
+    ID.ConstantVal = C;
+    ID.Kind = ValID::t_ConstantSplat;
----------------
nikic wrote:

I still don't understand the need for t_ConstantSplat. What goes wrong if you set ConstantVal to ConstantVector::getSplat() in here?

https://github.com/llvm/llvm-project/pull/74620