[llvm] [DWARFLinker][DWARFLinkerParallel] Refactor DWARFLinker&DWARFLinkerParallel to have a common library. (PR #74725)

via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 7 08:36:20 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff f1200ca7ac88c6ff9aa4fe3b560cf326dc3d4e25 27f717a4b2c2c10f3481efa36b0790ad35dc9ce5 -- llvm/include/llvm/DWARFLinker/DWARFLinkerBase.h llvm/include/llvm/DWARFLinker/LLVM/DWARFLinker.h llvm/lib/DWARFLinker/LLVM/DWARFLinker.cpp bolt/lib/Rewrite/DWARFRewriter.cpp llvm/include/llvm/DebugInfo/DWARF/DWARFDebugMacro.h llvm/include/llvm/DebugInfo/DWARF/DWARFUnit.h llvm/lib/DebugInfo/DWARF/DWARFDebugLine.cpp llvm/tools/dsymutil/DwarfLinkerForBinary.cpp llvm/tools/dsymutil/DwarfLinkerForBinary.h llvm/tools/dsymutil/LinkUtils.h llvm/tools/dsymutil/dsymutil.cpp llvm/tools/llvm-dwarfutil/DebugInfoLinker.cpp llvm/unittests/DWARFLinkerParallel/StringPoolTest.cpp llvm/include/llvm/DWARFLinker/AddressesMap.h llvm/include/llvm/DWARFLinker/Apple/DWARFLinker.h llvm/include/llvm/DWARFLinker/Apple/DWARFLinkerCompileUnit.h llvm/include/llvm/DWARFLinker/Apple/DWARFLinkerDeclContext.h llvm/include/llvm/DWARFLinker/Apple/DWARFStreamer.h llvm/include/llvm/DWARFLinker/ArrayList.h llvm/include/llvm/DWARFLinker/DWARFFile.h llvm/include/llvm/DWARFLinker/IndexedValuesMap.h llvm/include/llvm/DWARFLinker/StringPool.h llvm/include/llvm/DWARFLinker/Utils.h llvm/lib/DWARFLinker/Apple/DWARFLinker.cpp llvm/lib/DWARFLinker/Apple/DWARFLinkerCompileUnit.cpp llvm/lib/DWARFLinker/Apple/DWARFLinkerDeclContext.cpp llvm/lib/DWARFLinker/Apple/DWARFStreamer.cpp llvm/lib/DWARFLinker/LLVM/AcceleratorRecordsSaver.cpp llvm/lib/DWARFLinker/LLVM/AcceleratorRecordsSaver.h llvm/lib/DWARFLinker/LLVM/DIEAttributeCloner.cpp llvm/lib/DWARFLinker/LLVM/DIEAttributeCloner.h llvm/lib/DWARFLinker/LLVM/DIEGenerator.h llvm/lib/DWARFLinker/LLVM/DWARFEmitterImpl.cpp llvm/lib/DWARFLinker/LLVM/DWARFEmitterImpl.h llvm/lib/DWARFLinker/LLVM/DWARFLinkerCompileUnit.cpp llvm/lib/DWARFLinker/LLVM/DWARFLinkerCompileUnit.h llvm/lib/DWARFLinker/LLVM/DWARFLinkerGlobalData.h llvm/lib/DWARFLinker/LLVM/DWARFLinkerImpl.cpp llvm/lib/DWARFLinker/LLVM/DWARFLinkerImpl.h llvm/lib/DWARFLinker/LLVM/DWARFLinkerTypeUnit.cpp llvm/lib/DWARFLinker/LLVM/DWARFLinkerTypeUnit.h llvm/lib/DWARFLinker/LLVM/DWARFLinkerUnit.cpp llvm/lib/DWARFLinker/LLVM/DWARFLinkerUnit.h llvm/lib/DWARFLinker/LLVM/DebugLineSectionEmitter.h llvm/lib/DWARFLinker/LLVM/DependencyTracker.cpp llvm/lib/DWARFLinker/LLVM/DependencyTracker.h llvm/lib/DWARFLinker/LLVM/OutputSections.cpp llvm/lib/DWARFLinker/LLVM/OutputSections.h llvm/lib/DWARFLinker/LLVM/StringEntryToDwarfStringPoolEntryMap.h llvm/lib/DWARFLinker/LLVM/SyntheticTypeNameBuilder.cpp llvm/lib/DWARFLinker/LLVM/SyntheticTypeNameBuilder.h llvm/lib/DWARFLinker/LLVM/TypePool.h llvm/lib/DWARFLinker/Utils.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/bolt/lib/Rewrite/DWARFRewriter.cpp b/bolt/lib/Rewrite/DWARFRewriter.cpp
index 830d43f781..c8c04c7ebb 100644
--- a/bolt/lib/Rewrite/DWARFRewriter.cpp
+++ b/bolt/lib/Rewrite/DWARFRewriter.cpp
@@ -452,7 +452,8 @@ createDIEStreamer(const Triple &TheTriple, raw_pwrite_stream &OutFile,
                   DWARFRewriter &Rewriter) {
 
   std::unique_ptr<DIEStreamer> Streamer = std::make_unique<DIEStreamer>(
-      &DIEBldr, Rewriter, llvm::dwarflinker::DWARFLinker::OutputFileType::Object, OutFile,
+      &DIEBldr, Rewriter,
+      llvm::dwarflinker::DWARFLinker::OutputFileType::Object, OutFile,
       [](StringRef Input) -> StringRef { return Input; },
       [&](const Twine &Warning, StringRef Context, const DWARFDie *) {});
   Error Err = Streamer->init(TheTriple, Swift5ReflectionSegmentName);

``````````

</details>


https://github.com/llvm/llvm-project/pull/74725


More information about the llvm-commits mailing list