[llvm] [LLVM][IR] Add textual shorthand for specifying constant vector splats. (PR #74620)

[Nikita Popov via llvm-commits]

================
@@ -3981,6 +3981,33 @@ bool LLParser::parseValID(ValID &ID, PerFunctionState *PFS, Type *ExpectedTy) {
     return false;
   }
 
+  case lltok::kw_splat: {
+    Lex.Lex();
+    if (parseToken(lltok::lparen, "expected '(' after vector splat"))
+      return true;
+    Constant *C;
+    if (parseGlobalTypeAndValue(C))
+      return true;
+    if (parseToken(lltok::rparen, "expected ')' at end of vector splat"))
+      return true;
+
+    if (auto *CI = dyn_cast<ConstantInt>(C)) {
----------------
nikic wrote:

While representing them as t_APSInt/t_APFloat is *possible*, I don't think this is actually required and just using the t_Constant case should work fine, similar to how it works for constant expression.

https://github.com/llvm/llvm-project/pull/74620