[llvm] [llvm-exegesis] Add explicit error message with segfault address (PR #74210)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 7 01:30:53 PST 2023


================
@@ -41,14 +43,19 @@ class ClusteringError : public ErrorInfo<ClusteringError> {
 class SnippetCrash : public ErrorInfo<SnippetCrash> {
 public:
   static char ID;
-  SnippetCrash(const Twine &S) : Msg(S.str()) {}
+  SnippetCrash(const Twine &S)
----------------
boomanaiden154 wrote:

Ah, makes sense.

Either way I think we would need a conditional there to send appropriate diagnostics to the user, but a generic separate error would be more scalable than individual error classes. I'm not sure there's a large benefit to separating out the error classes though, especially given it would end up looking pretty similar to D158052. What do you think is best in this situation?

https://github.com/llvm/llvm-project/pull/74210


More information about the llvm-commits mailing list