[llvm] [llvm-exegesis] Add explicit error message with segfault address (PR #74210)

Clement Courbet via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 7 00:58:19 PST 2023


================
@@ -41,14 +43,19 @@ class ClusteringError : public ErrorInfo<ClusteringError> {
 class SnippetCrash : public ErrorInfo<SnippetCrash> {
 public:
   static char ID;
-  SnippetCrash(const Twine &S) : Msg(S.str()) {}
+  SnippetCrash(const Twine &S)
----------------
legrosbuffle wrote:

Any reason not to generate the message when constructing the `SnippetCrash` ? It feels like storing theaddress and signal number is not really useful if they are not accessible (or if they are, they we should have two different errors for `SnippetFailed` and `SnippetCrashed`).

https://github.com/llvm/llvm-project/pull/74210


More information about the llvm-commits mailing list