[llvm] [clang] [clang] NFC: Deprecate `FileEntry::getName()` (PR #68157)

Ben Langmuir via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 09:14:15 PST 2023


================
@@ -157,6 +157,25 @@
 #define LLVM_DEPRECATED(MSG, FIX) [[deprecated(MSG)]]
 #endif
 
+// clang-format off
+#if defined(__clang__) || defined(__GNUC__)
+#define LLVM_IGNORE_DEPRECATIONS_OF_DECLARATIONS_BEGIN                         \
----------------
benlangmuir wrote:

I'm not sure how often the general form of this is useful - I don't actually see many places in the code that disable diagnostics for both MSVC and clang/gcc.  So I would stick with the version that is specific to deprecations.  Maybe you should more closely match the name of `_LIBCPP_SUPPRESS_DEPRECATED_PUSH`  -- e.g. `LLVM_SUPPRESS_DEPRECATED_PUSH` and `..._POP`. 


https://github.com/llvm/llvm-project/pull/68157


More information about the llvm-commits mailing list