[llvm] [NFC][DebugInfo][RemoveDIs] Use iterators to insert in callsite-splitting (PR #74455)

[Jeremy Morse via llvm-commits]

jmorse wrote:

Reverted as some buildbots complained; closer inspection of the final part of the diff reveals the problem:

``

https://github.com/llvm/llvm-project/pull/74455