[llvm] [VFABI] Improve VFABI unit tests (PR #73907)

[Paul Walker via llvm-commits]

================
@@ -40,61 +38,45 @@ class VFABIParserTest : public ::testing::Test {
   LLVMContext Ctx;
   SMDiagnostic Err;
   std::unique_ptr<Module> M;
-  FunctionType *FTy;
+  FunctionType *ScalarFTy = nullptr;
   FunctionCallee F;
 
 protected:
-  // Referencies to the parser output field.
+  // References to the parser output field.
   ElementCount &VF = Info.Shape.VF;
   VFISAKind &ISA = Info.ISA;
-  SmallVector<VFParameter, 8> &Parameters = Info.Shape.Parameters;
+  SmallVector<VFParameter, 8> &VecFuncParameters = Info.Shape.Parameters;
----------------
paulwalker-arm wrote:

I know this change was requested but it doesn't look correct to me.  These protected members are clearly defined as shortcuts to the underlying field within VFInfo and given all the others use the same name I don't see why `Parameters` should be treated differently?

https://github.com/llvm/llvm-project/pull/73907