[llvm] [AMDGPU] Simplify WaitcntBrackets::getRegInterval with getPhysRegBaseClass (PR #74087)

Carl Ritson via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 23:50:08 PST 2023


================
@@ -525,7 +524,7 @@ RegInterval WaitcntBrackets::getRegInterval(const MachineInstr *MI,
   else
     return {-1, -1};
 
-  const TargetRegisterClass *RC = TII->getOpRegClass(*MI, OpNo);
+  const TargetRegisterClass *RC = TRI->getPhysRegBaseClass(Op.getReg());
----------------
perlfu wrote:

We should probably be asserting this is a physical register here?
i.e. `assert(!Op.getReg().isVirtual())`

`getPhysRegBaseClass` will return null for virtuals, etc, so alternatively/additionally assert RC is valid?

https://github.com/llvm/llvm-project/pull/74087


More information about the llvm-commits mailing list