[llvm] [MsgPack] Return an Error instead of bool from readFromBlob (PR #74357)
    Alexander Richardson via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Dec  4 14:41:28 PST 2023
    
    
  
================
@@ -5513,41 +5513,42 @@ static AMDNote getAMDNote(uint32_t NoteType, ArrayRef<uint8_t> Desc) {
 struct AMDGPUNote {
   std::string Type;
   std::string Value;
+  bool IsError;
 };
 
 template <typename ELFT>
 static AMDGPUNote getAMDGPUNote(uint32_t NoteType, ArrayRef<uint8_t> Desc) {
----------------
arichardson wrote:
Maybe this should return Expected<AMDGPUNote> instead of adding the extra boolean field?
https://github.com/llvm/llvm-project/pull/74357
    
    
More information about the llvm-commits
mailing list