[llvm] [InstrRef][nfc] Remove usage of unique_ptrs of arrays (PR #74203)

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 3 09:17:52 PST 2023


================
@@ -1200,21 +1200,21 @@ class InstrRefBasedLDV : public LDVImpl {
   /// exists, otherwise returns std::nullopt.
   std::optional<ValueIDNum> getValueForInstrRef(unsigned InstNo, unsigned OpNo,
                                                 MachineInstr &MI,
-                                                const ValueTable *MLiveOuts,
-                                                const ValueTable *MLiveIns);
+                                                const FuncValueTable *MLiveOuts,
+                                                const FuncValueTable *MLiveIns);
----------------
dwblaikie wrote:

Given the old patch passed a pointer to the start of a contiguous sequence, it made sense for it to be a pointer. But the new thing is passing a pointer to a sequence, not the start of it, so I think maybe /this/ patch is the one where this should change from a pointer to a reference, rather than waiting to do that in a follow-on patch.

https://github.com/llvm/llvm-project/pull/74203


More information about the llvm-commits mailing list