[llvm] 38f75d6 - [llvm-exegesis] Removed useless test

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 2 18:04:53 PST 2023


Author: Aiden Grossman
Date: 2023-12-02T18:04:03-08:00
New Revision: 38f75d606f94e6b552fd74d487b061a1f8f907fa

URL: https://github.com/llvm/llvm-project/commit/38f75d606f94e6b552fd74d487b061a1f8f907fa
DIFF: https://github.com/llvm/llvm-project/commit/38f75d606f94e6b552fd74d487b061a1f8f907fa.diff

LOG: [llvm-exegesis] Removed useless test

This test was an exact duplicate of the one above, providing no value,
and also adding confusion as it referred to a behavior that (was
presumably) moved around and tested differently during the review
process with the test being forgotten about.

Added: 
    

Modified: 
    llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp b/llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp
index b05a713351514..2bab3aa15baad 100644
--- a/llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp
+++ b/llvm/unittests/tools/llvm-exegesis/X86/SnippetFileTest.cpp
@@ -209,15 +209,6 @@ TEST_F(X86SnippetFileTest, MemoryMappingNoDefinition) {
   consumeError(std::move(Error));
 }
 
-TEST_F(X86SnippetFileTest, IncompatibleExecutorMode) {
-  auto Error = TestCommon(R"(
-    # LLVM-EXEGESIS-MEM-MAP test1 4096
-  )")
-                   .takeError();
-  EXPECT_TRUE((bool)Error);
-  consumeError(std::move(Error));
-}
-
 } // namespace
 } // namespace exegesis
 } // namespace llvm


        


More information about the llvm-commits mailing list