[compiler-rt] [asan][win][msvc] override new and delete and seperate TUs (PR #68754)

via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 13:21:12 PST 2023


zeroomega wrote:

Hi, this patch breaks runtime build on mac. We are seeing following build errors on our Mac bots:

```
-- Configuring done (11.0s)
CMake Error at /Volumes/Work/s/w/ir/x/w/llvm-llvm-project/compiler-rt/cmake/Modules/AddCompilerRT.cmake:75 (add_library):
  Cannot find source file:

    ASAN_CXX_SOURCES
Call Stack (most recent call first):
  /Volumes/Work/s/w/ir/x/w/llvm-llvm-project/compiler-rt/lib/asan/CMakeLists.txt:173 (add_compiler_rt_object_libraries)
```

I believe the error is caused by https://github.com/llvm/llvm-project/commit/481e9b3e0b9c0a6843261f060822c7a41387e28c#diff-e07727916fd4838a70b92fe6a62b5c6b52b8db246579951b16498628091e05c1R48
At Line 48, it assigned the string "ASAN_CXX_SOURCES" to `ASAN_SOURCES` variable instead assigning the list of files in `ASAN_CXX_SOURCES` variable to `ASAN_SOURCES`. 
Could you revert your change and correct the issue please?

https://github.com/llvm/llvm-project/pull/68754


More information about the llvm-commits mailing list