[llvm] [RISCV] Remove null terminator from CSRegs in determineCalleeSaves. (PR #74131)

Craig Topper via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 11:12:58 PST 2023


https://github.com/topperc created https://github.com/llvm/llvm-project/pull/74131

Presumably this was done to make it similar to the getCalleeSavedRegs list in RegInfo, but its simpler to use a range based for loop over the array.

>From a4270f9f9cf843ba21266ba04454ba7072194fdc Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Fri, 1 Dec 2023 11:10:35 -0800
Subject: [PATCH] [RISCV] Remove null terminator from CSRegs in
 determineCalleeSaves.

Presumably this was done to make it similar to the getCalleeSavedRegs
list in RegInfo, but its simpler to use a range based for loop over
the array.
---
 llvm/lib/Target/RISCV/RISCVFrameLowering.cpp | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/lib/Target/RISCV/RISCVFrameLowering.cpp b/llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
index 1709ac28d3c5687..8dfea6d3862057c 100644
--- a/llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
+++ b/llvm/lib/Target/RISCV/RISCVFrameLowering.cpp
@@ -981,11 +981,11 @@ void RISCVFrameLowering::determineCalleeSaves(MachineFunction &MF,
       RISCV::X5, RISCV::X6, RISCV::X7,                  /* t0-t2 */
       RISCV::X10, RISCV::X11,                           /* a0-a1, a2-a7 */
       RISCV::X12, RISCV::X13, RISCV::X14, RISCV::X15, RISCV::X16, RISCV::X17,
-      RISCV::X28, RISCV::X29, RISCV::X30, RISCV::X31, 0 /* t3-t6 */
+      RISCV::X28, RISCV::X29, RISCV::X30, RISCV::X31 /* t3-t6 */
     };
 
-    for (unsigned i = 0; CSRegs[i]; ++i)
-      SavedRegs.set(CSRegs[i]);
+    for (auto Reg : CSRegs)
+      SavedRegs.set(Reg);
 
     if (MF.getSubtarget<RISCVSubtarget>().hasStdExtF()) {
 



More information about the llvm-commits mailing list