[llvm] [AArch64] Stack probing for dynamic allocas in SelectionDAG (PR #66525)

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 12:15:08 PST 2023


efriedma-quic wrote:

Oh, I see, the new code is effectively guarded by an `!isTargetWindows()`.  I guess that's fine, then.  Opened #73975 to track the Windows-specific bits I've noted on the reviews.

You might want to put a note in AArch64FrameLowering::hasReservedCallFrame mentioning that you're making assumptions about the implementation elsewhere.  (We could conceivably mess with the way that works in the future.)

https://github.com/llvm/llvm-project/pull/66525


More information about the llvm-commits mailing list