[llvm] [VFABI] Improve VFABI unit tests (PR #73907)
Graham Hunter via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 30 07:41:42 PST 2023
================
@@ -350,61 +405,63 @@ TEST_F(VFABIParserTest, ISAIndependentMangling) {
#define __COMMON_CHECKS \
do { \
EXPECT_EQ(VF, ElementCount::getFixed(2)); \
- EXPECT_FALSE(IsMasked()); \
- EXPECT_EQ(Parameters.size(), (unsigned)10); \
- EXPECT_EQ(Parameters, ExpectedParams); \
- EXPECT_EQ(ScalarName, "sin"); \
+ EXPECT_FALSE(isMasked()); \
+ EXPECT_TRUE(matchScalarParamNum()) \
+ << "Different number of Scalar parameters"; \
+ EXPECT_EQ(VecFuncParameters.size(), (unsigned)10); \
+ EXPECT_EQ(VecFuncParameters, ExpectedParams); \
+ EXPECT_EQ(ScalarName, "foo"); \
+ EXPECT_EQ(VectorName, "vector_foo"); \
} while (0)
// Advanced SIMD: <isa> = "n"
- EXPECT_TRUE(invokeParser("_ZGVnN2vls2Ls27Us4Rs5l1L10U100R1000u_sin"));
+ EXPECT_TRUE(invokeParser(
----------------
huntergr-arm wrote:
These feel like a duplicate of the 'VFABIParserTest, ISA' subtest above, though they do check more properties.
https://github.com/llvm/llvm-project/pull/73907
More information about the llvm-commits
mailing list