[llvm] [DebugInfo] Set all dbg.value intrinsics to be tail-calls (PR #73661)

Orlando Cazalet-Hyams via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 04:35:07 PST 2023


================
@@ -988,9 +988,11 @@ Instruction *DIBuilder::insertDbgValueIntrinsic(Value *V,
                                                 DIExpression *Expr,
                                                 const DILocation *DL,
                                                 Instruction *InsertBefore) {
-  return insertDbgValueIntrinsic(
+  Instruction *DVI = insertDbgValueIntrinsic(
       V, VarInfo, Expr, DL, InsertBefore ? InsertBefore->getParent() : nullptr,
       InsertBefore);
+  cast<CallInst>(DVI)->setTailCall();
----------------
OCHyams wrote:

It seems harmless to cover dbg.declares too to me, given

> This change has no meaningful effect on the compiler

But I won't insist

https://github.com/llvm/llvm-project/pull/73661


More information about the llvm-commits mailing list