[llvm] 'Soft Stop' solution on offset overflow issue: By Produceing a truncated but valid DWP file, discarding any DWO files that would not fit within the 32 bit/4GB limits of the format. (PR #71902)

Alexander Yermolovich via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 17:24:16 PST 2023


================
@@ -273,9 +282,12 @@ static Error addAllTypesFromTypesSection(
       uint32_t OldOffset = TypesOffset;
       TypesOffset += C.getLength32();
       if (OldOffset > TypesOffset) {
-        if (Error Err = sectionOverflowErrorOrWarning(
-                OldOffset, TypesOffset, "types", ContinueOnCuIndexOverflow))
+        if (Error Err = sectionOverflowErrorOrWarning(OldOffset, TypesOffset,
+                                                      "Types", OverflowOptValue,
+                                                      AnySectionOverflow))
           return Err;
+        if (AnySectionOverflow)
----------------
ayermolo wrote:

Same comment as above.

https://github.com/llvm/llvm-project/pull/71902


More information about the llvm-commits mailing list