[llvm] [libcxx] remove linux buildkite builders entirely (PR #73825)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 29 12:12:30 PST 2023
https://github.com/EricWF updated https://github.com/llvm/llvm-project/pull/73825
>From 5a11a7998d975dd9286df9c74bb2b9ed161e3a54 Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Wed, 29 Nov 2023 12:18:00 -0500
Subject: [PATCH 1/4] remove linux buildkite builders entirely
---
.github/workflows/libcxx-build-and-test.yaml | 4 ++++
libcxx/utils/ci/buildkite-pipeline.yml | 14 --------------
2 files changed, 4 insertions(+), 14 deletions(-)
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index dccfe54d4646767..5204fb4569ed309 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -158,6 +158,10 @@ jobs:
'generic-no-wide-characters',
'generic-static',
'generic-with_llvm_unwinder'
+ # TODO Find a better place for the benchmark and bootstrapping builds to live. They're either very expensive
+ # or don't provide much value since the benchmark run results are too noise on the bots.
+ 'benchmarks',
+ 'bootstrapping-build',
]
machine: [ 'libcxx-runners-8' ]
std_modules: [ 'OFF' ]
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 3c49247ab5aeeb9..7077f754220eb21 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -101,20 +101,6 @@ environment_definitions:
steps:
-- label: Bootstrapping build
- command: libcxx/utils/ci/run-buildbot bootstrapping-build
- env:
- <<: *common_env
- <<: *linux_agent
- <<: *common
-
-- label: Benchmarks
- command: libcxx/utils/ci/run-buildbot benchmarks
- env:
- <<: *common_env
- <<: *linux_agent
- <<: *common
-
- group: ':windows: Windows'
steps:
- label: Clang-cl (DLL)
>From 7f3962b3f0809e27735ebf21d2bcdd41bbe5a58f Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Wed, 29 Nov 2023 13:54:54 -0500
Subject: [PATCH 2/4] Fully remove the GCE buildkite builders on linux
---
libcxx/utils/ci/buildkite-pipeline.yml | 5 -----
1 file changed, 5 deletions(-)
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index 7077f754220eb21..db870a3a464527e 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -43,14 +43,9 @@ definitions:
# Define agents using YAML anchors to reduce duplication
agents_definitions:
- _linux_agent: &linux_agent
- agents:
- queue: libcxx-builders
- os: linux
_windows_agent: &windows_agent
agents:
queue: windows
-
# Mac OS Builders
_mac_agent_x86: &mac_agent_x86
agents:
>From e2a8facb79fa9c3a0e9cd266be084a3d85355a1f Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Wed, 29 Nov 2023 15:06:47 -0500
Subject: [PATCH 3/4] regenerate diff
---
libcxx/utils/ci/buildkite-pipeline.yml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index db870a3a464527e..51b9999026247fd 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -46,6 +46,7 @@ agents_definitions:
_windows_agent: &windows_agent
agents:
queue: windows
+
# Mac OS Builders
_mac_agent_x86: &mac_agent_x86
agents:
@@ -208,6 +209,11 @@ steps:
<<: *arm_agent_armv8l
<<: *common
+ - label: Armv7-M picolibc
+ command: libcxx/utils/ci/run-buildbot armv7m-picolibc
+ <<: *arm_agent_aarch64
+ <<: *common
+
- group: AIX
steps:
- label: AIX (32-bit)
>From 0fc20869a5ee50f873232f5b873f8efb685c9265 Mon Sep 17 00:00:00 2001
From: eric <eric at efcs.ca>
Date: Wed, 29 Nov 2023 15:12:17 -0500
Subject: [PATCH 4/4] fix pipeline
---
.github/workflows/libcxx-build-and-test.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 5204fb4569ed309..eb7072ea18aae20 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -157,11 +157,11 @@ jobs:
'generic-no-unicode',
'generic-no-wide-characters',
'generic-static',
- 'generic-with_llvm_unwinder'
+ 'generic-with_llvm_unwinder',
# TODO Find a better place for the benchmark and bootstrapping builds to live. They're either very expensive
# or don't provide much value since the benchmark run results are too noise on the bots.
'benchmarks',
- 'bootstrapping-build',
+ 'bootstrapping-build'
]
machine: [ 'libcxx-runners-8' ]
std_modules: [ 'OFF' ]
More information about the llvm-commits
mailing list