[llvm] [MachineScheduler][NFCI] Add Offset and OffsetIsScalable args to shouldClusterMemOps (PR #73778)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 29 10:20:34 PST 2023


================
@@ -1496,12 +1496,18 @@ class TargetInstrInfo : public MCInstrInfo {
   /// to TargetPassConfig::createMachineScheduler() to have an effect.
   ///
   /// \p BaseOps1 and \p BaseOps2 are memory operands of two memory operations.
+  /// \p Offset1 and \p Offset2 are the byte offsets for the memory
----------------
preames wrote:

That is a good point.  I don't think ElementCount can be negative.  We could either introduce a new subclass of FixedOrScalableQuantity, or just go with what @asb proposed.

https://github.com/llvm/llvm-project/pull/73778


More information about the llvm-commits mailing list