[llvm] [DebugInfo] Set all dbg.value intrinsics to be tail-calls (PR #73661)

[Orlando Cazalet-Hyams via llvm-commits]

================
@@ -988,9 +988,11 @@ Instruction *DIBuilder::insertDbgValueIntrinsic(Value *V,
                                                 DIExpression *Expr,
                                                 const DILocation *DL,
                                                 Instruction *InsertBefore) {
-  return insertDbgValueIntrinsic(
+  Instruction *DVI = insertDbgValueIntrinsic(
       V, VarInfo, Expr, DL, InsertBefore ? InsertBefore->getParent() : nullptr,
       InsertBefore);
+  cast<CallInst>(DVI)->setTailCall();
----------------
OCHyams wrote:

Would it be better to put this change in `DIBuilder::insertDbgIntrinsic`, which seems to be the common leaf between all the `insertDbgXIntrinsic` functions (that's where the `IRBuilder::CreateCall` call is)?

https://github.com/llvm/llvm-project/pull/73661