[llvm] [SystemZ][z/OS] yaml2obj header & end records (PR #73696)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 12:13:23 PST 2023


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff 3a6f02a6581b49b269710eea944dc114166403ed fdc513bb2a28d4b089969b36d4a80d606006509a -- llvm/include/llvm/ObjectYAML/GOFFYAML.h llvm/lib/ObjectYAML/GOFFEmitter.cpp llvm/lib/ObjectYAML/GOFFYAML.cpp llvm/include/llvm/BinaryFormat/GOFF.h llvm/include/llvm/ObjectYAML/ObjectYAML.h llvm/include/llvm/ObjectYAML/yaml2obj.h llvm/lib/ObjectYAML/ObjectYAML.cpp llvm/lib/ObjectYAML/yaml2obj.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/ObjectYAML/GOFFEmitter.cpp b/llvm/lib/ObjectYAML/GOFFEmitter.cpp
index 3213e5928f..4a43cff193 100644
--- a/llvm/lib/ObjectYAML/GOFFEmitter.cpp
+++ b/llvm/lib/ObjectYAML/GOFFEmitter.cpp
@@ -22,7 +22,7 @@ using namespace llvm;
 
 namespace {
 
-//static const uint8_t TXTMaxDataLength = 56;
+// static const uint8_t TXTMaxDataLength = 56;
 
 // Common flag values on records.
 enum {
@@ -193,9 +193,9 @@ void GOFFOstream::write_impl(const char *Ptr, size_t Size) {
 class GOFFState {
   void writeHeader(GOFFYAML::FileHeader &FileHdr);
   void writeEnd();
-//  void writeSymbol(GOFFYAML::Symbol Sym);
-//  void writeSection(GOFFYAML::Section Sec);
-//  void writeRelocationDirectory(GOFFYAML::Relocations Rel);
+  //  void writeSymbol(GOFFYAML::Symbol Sym);
+  //  void writeSection(GOFFYAML::Section Sec);
+  //  void writeRelocationDirectory(GOFFYAML::Relocations Rel);
 
   void reportError(const Twine &Msg) {
     ErrHandler(Msg);
@@ -204,8 +204,8 @@ class GOFFState {
 
   GOFFState(raw_ostream &OS, GOFFYAML::Object &Doc,
             yaml::ErrorHandler ErrHandler)
-      : GW(OS), Doc(Doc), ErrHandler(ErrHandler), /*SymbolID(0),*/ HasError(false) {
-  }
+      : GW(OS), Doc(Doc), ErrHandler(ErrHandler),
+        /*SymbolID(0),*/ HasError(false) {}
 
   ~GOFFState() { GW.finalize(); }
 
@@ -219,7 +219,7 @@ private:
   GOFFOstream GW;
   GOFFYAML::Object &Doc;
   yaml::ErrorHandler ErrHandler;
-  //uint16_t SymbolID;
+  // uint16_t SymbolID;
   bool HasError;
 };
 
@@ -421,17 +421,17 @@ bool GOFFState::writeObject() {
   if (HasError)
     return false;
   // Iterate over all records.
-/*  for (auto &Rec : Doc.Records) {
-    if (auto *Rel = dyn_cast<GOFFYAML::Relocations>(Rec.get())) {
-      writeRelocationDirectory(*Rel);
-    } else if (auto *Sec = dyn_cast<GOFFYAML::Section>(Rec.get())) {
-      writeSection(*Sec);
-    } else if (auto *Sym = dyn_cast<GOFFYAML::Symbol>(Rec.get())) {
-      writeSymbol(*Sym);
-    } else {
-      reportError("Unknown record type");
-    }
-  }*/
+  /*  for (auto &Rec : Doc.Records) {
+      if (auto *Rel = dyn_cast<GOFFYAML::Relocations>(Rec.get())) {
+        writeRelocationDirectory(*Rel);
+      } else if (auto *Sec = dyn_cast<GOFFYAML::Section>(Rec.get())) {
+        writeSection(*Sec);
+      } else if (auto *Sym = dyn_cast<GOFFYAML::Symbol>(Rec.get())) {
+        writeSymbol(*Sym);
+      } else {
+        reportError("Unknown record type");
+      }
+    }*/
   writeEnd();
   return true;
 }

``````````

</details>


https://github.com/llvm/llvm-project/pull/73696


More information about the llvm-commits mailing list