[llvm] [InstCombine] Do not simplify lshr/shl arg if it is part of fshl rotate pattern. (PR #73441)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 28 08:24:18 PST 2023


goldsteinn wrote:

> > I would expect to see test difference in the commit adding the new restriction.
> 
> I didn't get what you meant by this. Should I have code changes and test in the same commit?

Yes, otherwise the commit with the impl will not be passing (and it makes review more difficult as its hard to see the proper side affects of a change).

https://github.com/llvm/llvm-project/pull/73441


More information about the llvm-commits mailing list