[llvm] [AMDGPU] Defaults for missing dimensions in SYCL required wg size (PR #72652)
Matt Arsenault via llvm-commits
llvm-commits at lists.llvm.org
Tue Nov 28 03:33:37 PST 2023
================
@@ -173,14 +173,18 @@ std::string MetadataStreamerMsgPackV4::getTypeName(Type *Ty,
}
msgpack::ArrayDocNode
-MetadataStreamerMsgPackV4::getWorkGroupDimensions(MDNode *Node) const {
+MetadataStreamerMsgPackV4::getWorkGroupDimensions(const Function &Func,
+ MDNode *Node) const {
auto Dims = HSAMetadataDoc->getArrayNode();
- if (Node->getNumOperands() != 3)
+ if (Node->getNumOperands() != 3 && !Func.hasFnAttribute("sycl-module-id"))
----------------
arsenm wrote:
The attribute check should not be necessary. The metadata should have a standalone interpretation and not depend on any other attributes
https://github.com/llvm/llvm-project/pull/72652
More information about the llvm-commits
mailing list