[llvm] [AMDGPU] Introduce llvm.amdgcn.image.atomic.load intrinsic. (PR #73613)

Carl Ritson via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 27 23:54:17 PST 2023


perlfu wrote:

I think the PR description needs to be clearer:
- This adds ordering parameters to all *existing* atomic intrinsics. So this will require changes in LLVM IR code generators.
- New intrinsic atomic.load does not implicitly have acquire semantics, this is just the ordering provided in the lit test.

If ordering parameter is to be added to all intrinsics then I suspect there needs to be more test coverage that the full range of these values make their way to MIR and manifest the expected effects.

https://github.com/llvm/llvm-project/pull/73613


More information about the llvm-commits mailing list