[llvm] a9e3d23 - Revert "[runtimes] Add missing test dependencies to check-all (#72955)"

[Hans Wennborg via llvm-commits]

Author: Hans Wennborg
Date: 2023-11-27T13:05:02+01:00
New Revision: a9e3d232a520a17f098d4dc872c9591c565e7d36

URL: https://github.com/llvm/llvm-project/commit/a9e3d232a520a17f098d4dc872c9591c565e7d36
DIFF: https://github.com/llvm/llvm-project/commit/a9e3d232a520a17f098d4dc872c9591c565e7d36.diff

LOG: Revert "[runtimes] Add missing test dependencies to check-all (#72955)"

This caused some runtimes builds to fail with:
error: unknown target 'runtimes-test-depends'

See comments on the PR.

> The test-depends target contained all the dependencies needed to run the
> runtimes tests, but it was never added as a dependency of check-all.
> This caused some of the tsan tests to fail, since the custom libcxx
> build the tests were looking for was never built. Besides the tsan
> failures, this fixes all the other test failures I was seeing with:
> cmake -G Ninja -B release-build -S llvm \
>         -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
>         -DCMAKE_BUILD_TYPE=Release \
>         -DLLVM_ENABLE_ASSERTIONS=OFF \
>         -DLLVM_ENABLE_PROJECTS="clang;lld" \
>         -DLLVM_ENABLE_RUNTIMES="libcxx;libcxxabi;libunwind;compiler-rt"
>
> This is the same configuration the test-release.sh script uses, so I'm
> hoping this will also fix all the test failures we've been seeing when
> building the releases.
>
> Fixes #58680

This reverts commit 7f215b1380da49dccbf57da3040a40d25ed898f4.

Added: 
    

Modified: 
    llvm/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/CMakeLists.txt b/llvm/CMakeLists.txt
index e1712cf3e277ae6..1c983165b2ef003 100644
--- a/llvm/CMakeLists.txt
+++ b/llvm/CMakeLists.txt
@@ -1255,7 +1255,6 @@ if( LLVM_INCLUDE_TESTS )
   add_custom_target(test-depends
       DEPENDS ${LLVM_ALL_LIT_DEPENDS} ${LLVM_ALL_ADDITIONAL_TEST_DEPENDS})
   set_target_properties(test-depends PROPERTIES FOLDER "Tests")
-  add_dependencies(check-all test-depends)
 endif()
 
 if (LLVM_INCLUDE_DOCS)