[llvm] AMDGPU: Remove let Predicates from PredicateControl'd InstAliases (PR #73474)

[Ivan Kosarev via llvm-commits]

================
@@ -1069,10 +1067,13 @@ multiclass VOP3P_Real_MFMA_gfx940<bits<7> op, string Name = !cast<VOP3_Pseudo>(N
                     VOP3Pe_MAI <op, PS_VCD.Pfl, 0>;
   } // End AssemblerPredicate = isGFX940Plus, DecoderNamespace = "GFX940"
 
-  defm : VOP3P_Real_MFMA_gfx940_aliases<Name, PS_ACD.Mnemonic, NAME>;
+  let SubtargetPredicate = isGFX940Plus,
+      AssemblerPredicate = isGFX940Plus in {
----------------
kosarev wrote:

That duplicating `AssemblerPredicate` looks like we are trying to work around an overridden `SubtargetPredicate` somewhere. Is this because we do `SubtargetPredicate = HasMAIInsts` above? If so, can we do `OtherPredicates = [HasMAIInsts]` there and remove the `AssemblerPredicate` here?

https://github.com/llvm/llvm-project/pull/73474