[llvm] [InstCombine] Refactoring matchFunnelShift (NFC) (PR #73390)

[Nikita Popov via llvm-commits]

================
@@ -2810,7 +2809,7 @@ static Instruction *matchFunnelShift(Instruction &Or, InstCombinerImpl &IC,
       IsFshl = false; // Sub on SHL.
     }
     if (!ShAmt)
-      return nullptr;
+      return std::nullopt;
 
     FShiftArgs = {ShVal0, ShVal1, ShAmt};
   } else if (isa<ZExtInst>(Or0) || isa<ZExtInst>(Or1)) {
----------------
nikic wrote:

For the purpose you have in mind, I don't think this part should be extracted. Maybe @goldsteinn can confirm.

https://github.com/llvm/llvm-project/pull/73390