[llvm] [NFC][X86] Clang-format X86DisassemblerDecoderCommon.h (PR #73272)

Shengchen Kan via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 24 01:04:10 PST 2023


KanRobert wrote:

> Once a pull request has been created, please don't commit it until it's been approved (we don't want to muddy the waters between code that was judged to require precommit review, and code that wasn't - if a review is created, that communicates the intent that the code needs precommit review, and so committing it without that review is a mistake/missing that required review)

Oh, I see. I committed it w/o approval b/c I think it's a NFC and straightforward change. I think I should commit it w/o creating a PR next time. Thanks for the info.

https://github.com/llvm/llvm-project/pull/73272


More information about the llvm-commits mailing list